log lr hyperparams; add exact match rewards; fix qwen3-base configs; use user/system parts in prompts#3417
Closed
log lr hyperparams; add exact match rewards; fix qwen3-base configs; use user/system parts in prompts#3417
Conversation
…axtext into atwigg/add_qwen3_base
andytwigg
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
richjames0
requested changes
Mar 14, 2026
Collaborator
richjames0
left a comment
richjames0
left a comment
There was a problem hiding this comment.
Thanks Andy. This also includes a bunch of configs so maybe just update the PR title to reflect that
… __name__, add base models to globals.py
andytwigg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR includes several changes:
qwen3-base:
logging:
rewards:
check_numbersinstead of hardcoded 1.5reward_exact_answerreward (to separate from exact_format_match)check_answerdue to overlap withcheck_numberslora:
data:
promptsTests
this setup has been used to show gsm8k and openmath-instruct training on qwen3-{1-8}B
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.